Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies, fix breaking changes #154

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Update dependencies, fix breaking changes #154

wants to merge 1 commit into from

Conversation

tswaters
Copy link
Member

@tswaters tswaters commented Dec 1, 2022

  • promises from amqplib are no longer bluebird promises. Need to update a few instances of thenReturn and asCallback to work w/ native promises.

  • the replyQueue and exchange parameters are now objects instead of strings with {queue} and {exchange} referenced as the strings

  • re-ran npm run prettier as prettier was updated reapplying formatting

Fixes #153

@tswaters
Copy link
Member Author

tswaters commented Dec 1, 2022

I used npm@^7 to update dependencies and it seems to have updated both yarn.lock and package-lock.json files... probably fine :)

tswaters
tswaters commented Dec 1, 2022
View reviewed changes
.vscode/settings.json Outdated
@@ -0,0 +1,3 @@
{
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, will remove this from commit

Update dependencies, fix breaking changes
b04dd76 
* promises from amqplib are no longer bluebird promises.  Need to update
  a few instances of `thenReturn`, `asCallback`, and `.get` to work w/
  native promises.

* re-ran `npm run prettier` as prettier was updated reapplying formatting.
  Applied a few overrides to cut down on the diff. A few other changes
  are unavoidable (space after function keyword)

Fixes senecajs#153
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update library dependencies
1 participant
@tswaters